Re: [PATCH] hp-wmi: improve rfkill support

[Maciej Rutecki]

2009/7/23 Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>:

>
> That's a bug. ÂYou're saying this is in -rc4, without applying my patch?

Yes

>
> I think I know exactly what is happening. ÂApply my patch, and it will go
> away :-).

Yes. I add Your patch to -rc4 and rfkill works OK:
Enable by button:
root@gumis:/home/maciek# rfkill list
0: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no
1: hci0: Bluetooth
        Soft blocked: no
        Hard blocked: no
2: hp-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
3: hp-bluetooth: Bluetooth
        Soft blocked: no
        Hard blocked: no

Disable by button:
root@gumis:/home/maciek# rfkill list
0: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: yes
2: hp-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
3: hp-bluetooth: Bluetooth
        Soft blocked: no
        Hard blocked: no

After resume from s2disk:
root@gumis:/home/maciek# rfkill list
2: hp-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
3: hp-bluetooth: Bluetooth
        Soft blocked: no
        Hard blocked: no
4: phy1: Wireless LAN
        Soft blocked: no
        Hard blocked: yes

(are some differences after and before s2disk)

Enable by button:
root@gumis:/home/maciek# rfkill list
2: hp-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
3: hp-bluetooth: Bluetooth
        Soft blocked: no
        Hard blocked: no
4: phy1: Wireless LAN
        Soft blocked: no
        Hard blocked: no
5: hci0: Bluetooth
        Soft blocked: no
        Hard blocked: no

And wifi/bluetooth works without manual enable. Thanks.

>
> I'm not sure this is a new bug though. ÂIt might be triggered by the big
> rfkill rewrite, but I don't see how that could happen. ÂCan you confirm if
> this happens in 2.6.30?

2.6.30 works OK

>
> Thanks
> Alan
>


Regards
-- 
Maciej Rutecki
http://www.maciek.unixy.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/