Re: [PATCH] kernel.h: Verify that arguments to swap() are the sametype

[Andrew Morton]

On Wed, 15 Jul 2009 18:34:21 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> 
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index d6320a3..72878a5 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -637,8 +637,13 @@ static inline void ftrace_dump(void) { }
>  /*
>   * swap - swap value of @a and @b
>   */
> -#define swap(a, b) \
> -	do { typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; } while (0)
> +#define swap(a, b)				\
> +do {						\
> +	typeof(a) __tmp = (a);			\
> +	BUILD_BUG_ON(!__same_type(__tmp, (b)));	\
> +	(a) = (b);				\
> +	(b) = __tmp;				\
> +} while (0)
>  

I wonder if we can do

	typecheck(a, typeof(b));

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/