Re: [patch] x86 CPU detection for RDC

[Ingo Molnar]

* Mark Kelly <mark@xxxxxxxxxxxx> wrote:

 > From about 2.6.29, CPU detection appears to have changed such 
 > that
> a patch is required for RDC x86-compatible CPUs (possibly other 
> undetected x86 CPUs as well).  A work-around was to add a couple 
> of null checks to arch/x86/kernel/cpu/common.c, e.g.:
> 
> if (this_cpu && this_cpu->c_identify)
>              ~~~~~~~~~~~~~~~~~~~~~~~
>     this_cpu->c_identify(c);
> 
> However the patch below attempts to do this detection properly, 
> and also detect all variants of RDC CPUs. I have also added some 
> documentation for this platform.
> 
> See also:
> http://sites.google.com/site/bifferboard/Home/s3282-kernel-issues

ok, this definitely looks like a step in the right direction. The 
patch needs a few small fixes:

 - the one you sent was line-wrapped. (please see
   Documentation/email-clients.txt about how to send plain-text 
   patches.)

 - there's a few stylistic errors in the patch, 
   scripts/checkpatch.pl reports:

     total: 24 errors, 5 warnings, 0 checks, 157 lines checked

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/