Re: [PATCH 2/7] kfifo: move out spinlock

[Stefani Seibold]

Am Montag, den 17.08.2009, 11:52 +0200 schrieb Andi Kleen:
> > I think the break is not so hard if you believe. All you have to do is
> > to replace or kfifo_get() into kfifo_out_locked() and kfifo_put() into
> > kfifo_in_locked() if you really need the old behavior.
> > 
> > The thing is that we get no progress without changes.
> 
> One thing that would be good to ensure is that old unconverted code
> gets a clear compile time error, just in case some out of tree
> code uses it. 

This is already done.

> Bonus points also for having a short comment in kfifo.h that 
> explains how to do the conversion.
> 

I can do this on a maintainance patch.

> Other than that I would be all for getting rid of embedded spinlocks
> completely.
> 
> -Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/