Re: spin_is_locked() broken for uniprocessor?

From: Peter Zijlstra
Date: Wed Aug 19 2009 - 05:41:28 EST


On Wed, 2009-08-19 at 10:38 +0100, David Howells wrote:
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> > > which implies to me that spin_is_locked() will always return false. Is this
> > > expected behavior.
> >
> > That's wrong. spin_is_locked should always return true on UP.
>
> Surely it's not that simple? Maybe spin_is_lock() should be undefined on UP.

#define spin_is_locked(l) panic()

should sort things out quickly ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/