Re: [PATCH] intel-iommu: Work around yet another BIOS bug

From: Ray Lee
Date: Thu Aug 20 2009 - 15:30:13 EST


On Thu, Aug 20, 2009 at 1:01 AM, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
> + Â Â Â if (iommu->cap == (uint64_t)-1 && iommu->ecap == (uint64_t)-1) {
> + Â Â Â Â Â Â Â /* Promote an attitude of violence to a BIOS engineer today */
> + Â Â Â Â Â Â Â WARN(1, "Your BIOS is broken; DMAR reported at address %llx returns all ones!\n"

Think about changing this to a warning that "Your IOMMU appears to be
disabled." All ones is, after all, the traditional hint that the
device is turned off.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/