Re: [PATCH] Convert MMC subsys drivers to dev_pm_ops

[Nicolas Pitre]

On Sat, 22 Aug 2009, Marek Vasut wrote:

> Hi,
> 
> This converts most of the drivers found in drivers/mmc/host to dev_pm_ops.
> Also, it contains some fixes for the probe/remove functions in some cases.

Are you sure you're actually fixing things?

You replaced platform_driver_probe() calls with 
platform_driver_register() calls, and made the probe functions __devinit 
instead of __init.  Especially when the platform device is unlikely to 
go away or new ones to ever appear, there is no point keeping the 
probe code around after it is done.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/