Re: [PATCH 0/3]HTLB mapping for drivers (take 2)

From: Alexey Korolev
Date: Mon Aug 24 2009 - 02:14:37 EST


Mel,

> How about;
>
> Â Â Â Âo Extend Eric's helper slightly to take a GFP mask that is
> Â Â Â Â Âassociated with the inode and used for allocations from
> Â Â Â Â Âoutside the hugepage pool
> Â Â Â Âo A helper that returns the page at a given offset within
> Â Â Â Â Âa hugetlbfs file for population before the page has been
> Â Â Â Â Âfaulted.
>
> I know this is a bit hand-wavy, but it would allow significant sharing
> of the existing code and remove much of the hugetlbfs-awareness from
> your current driver.
>

I'm trying to write the solution you have described. The question I
have is about extension of hugetlb_file_setup function.
Is it supposed to allocate memory in hugetlb_file_setup function? Or
it is supposed to have reservation only.
If reservation only, then it is necessary to keep a gfp_mask for a
file somewhere. Would it be Ok to keep a gfp_mask for a file in
file->private_data?

Thanks,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/