Re: [PATCH] txx9wdt.c:52: Fix txx9wdt_probe() cleaning up aftererrors

From: Atsushi Nemoto
Date: Thu Aug 27 2009 - 10:57:06 EST


On Tue, 25 Aug 2009 11:20:26 +0200, Roel Kluin <roel.kluin@xxxxxxxxx> wrote:
> Make txx9wdt_probe() clean up after errors.
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> Any comments?

Well, why is this patch needed? I intentionally omitted iounmap and
release_mem_region because devres guarantee these resources are freed
on probe failure. Or are there any leaks?

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/