Re: [PATCH] tracing: Fix double CPP substitution in TRACE_EVENT_FN

[Josh Stone]

On 08/27/2009 03:50 PM, Frederic Weisbecker wrote:
> TRACE_EVENT_FN relays on TRACE_EVENT by reprocessing its parameters
> into the ftrace events CPP macro. This leads to a double substitution
> in some cases.
> 
> For example, a bad consequence is a format always prefixed by
> "%s, %s\n" for every TRACE_EVENT_FN based events.
> 
> Eg:
> 	cat /debug/tracing/events/syscalls/sys_enter/format
> 	[...]
> 	print fmt: "%s, %s\n", "\"NR %ld (%lx, %lx, %lx, %lx, %lx, %lx)\"",\
> 	"REC->id, REC->args[0], REC->args[1], REC->args[2], REC->args[3],\
> 	REC->args[4], REC->args[5]"
> 
> This creates a failure in post-processing tools such as perf trace or
> trace-cmd.

Fun - I didn't think about TP_printk and friends doing anything beside
passing their contents along.

> 
> Then drop this double substitution and replace it by a new __cpparg()
> macro that relays CPP arguments containing commas.

Looks good to me.

> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Josh Stone <jistone@xxxxxxxxxx>
> Cc: Li Zefan <lizf@xxxxxxxxxxxxxx>
> Cc: Steven Rostedt <srostedt@xxxxxxxxxx>
> Cc: Jason Baron <jbaron@xxxxxxxxxx>

Reviewed-by: Josh Stone <jistone@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/