RE: [PATCH] perf_counter: Fix a race on perf_counter_ctx
From: Metzger, Markus T
Date: Fri Aug 28 2009 - 05:57:32 EST
>-----Original Message-----
>From: Metzger, Markus T
>Sent: Tuesday, August 18, 2009 4:15 PM
>To: Ingo Molnar
>Cc: Peter Zijlstra; tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxx; markus.t.metzger@xxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx; Paul Mackerras
>Subject: RE: [PATCH] perf_counter: Fix a race on perf_counter_ctx
>
>>-----Original Message-----
>>From: Ingo Molnar [mailto:mingo@xxxxxxx]
>>Sent: Tuesday, August 18, 2009 4:00 PM
>>To: Metzger, Markus T
>>Cc: Peter Zijlstra; tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxx; markus.t.metzger@xxxxxxxxx; linux-
>>kernel@xxxxxxxxxxxxxxx; Paul Mackerras
>>Subject: Re: [PATCH] perf_counter: Fix a race on perf_counter_ctx
>>
>>
>>* Metzger, Markus T <markus.t.metzger@xxxxxxxxx> wrote:
>>
>>> Well, that would push out the limit a bit, but it would still be
>>> quite fragile.
>>>
>>> Currently, I'm not sure that this (i.e. that the interrupt
>>> handling takes too long) is the underlying problem of the hangs
>>> that I'm seeing.
>>
>>I havent seen a plausible theory yet about why an actual lockup
>>would happen on your box.
>
>So you do not think that taking too long in the ISR could cause this?
>
>And is it working on your box?
>
>
>>Does the timer IRQ perhaps slow down to such a degree that it can
>>never make progress and gets re-triggered again and again? We saw
>>such things with the function tracer.
>
>How would I test this?
>
>
>>Did the sampling of kernel-mode tasks ever work with the old BTS
>>code?
>
>The old BTS code used circular buffers.
Ingo,
I'm not making any progress with the kernel hang.
User-mode tracing is working OK (e.g. -e branches:u) and circular buffers are
working fine, as well. I can do "perf top -c 1 -e branches:u" and simultaneous
"perf record -c 1 -e branches:u", but as soon as I try to trace the kernel,
it hangs (and /var/log/messages is typically garbled).
Please drop the BTS patch.
thanks and regards,
markus.
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/