Re: [PATCH 13/23] io-controller: Separate out queue and data

[Rik van Riel]

Vivek Goyal wrote:
> o So far noop, deadline and AS had one common structure called *_data which
>   contained both the queue information where requests are queued and also
>   common data used for scheduling. This patch breaks down this common
>   structure in two parts, *_queue and *_data. This is along the lines of
>   cfq where all the reuquests are queued in queue and common data and tunables
>   are part of data.
>
> o It does not change the functionality but this re-organization helps once
>   noop, deadline and AS are changed to use hierarchical fair queuing.
>
> o looks like queue_empty function is not required and we can check for
>   q->nr_sorted in elevator layer to see if ioscheduler queues are empty or
>   not.
>
> Signed-off-by: Nauman Rafique <nauman@xxxxxxxxxx>
> Signed-off-by: Gui Jianfeng <guijianfeng@xxxxxxxxxxxxxx>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/