Re: [PATCH] TPM: Fixup pcrs sysfs file

From: Rajiv Andrade
Date: Mon Sep 14 2009 - 13:46:08 EST


On Mon, 2009-09-14 at 00:25 -0600, Jason Gunthorpe wrote:
> On Mon, Sep 14, 2009 at 12:36:39PM +1000, James Morris wrote:
> > On Thu, 3 Sep 2009, Jason Gunthorpe wrote:
>
> > > > That sounds like a fairly serious bug, and this looks like a 2.6.31
> > > > patch.
> >
> > Any comments from the maintainers on this patch?
>

Sorry for the delay, just reviewed the patches and Jason is right,
Jason's and Andrew's final work (last patch) is great.

> FWIW, I didn't mention in the patch emails, but all the patches I sent
> fix regressions that have been introduced in the past couple years by
> clean up patches that never tested the code paths they alter.
>

Hold on, I tested these functions before when submitting them and they
worked fine, and, I couldn't figure it out why yet (only guesses), they
still work for me here, probably due the mishandling of the be32
formatted value when calling transmit_cmd().


Thanks,
Rajiv

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/