Re: [PATCH 3/5] checkpatch: add a blacklist

From: Li Zefan
Date: Tue Sep 22 2009 - 02:30:59 EST


Daniel Walker wrote:
> There are times when maintainers intentially don't follow the coding
> style. When that happens it means some errors need to be ignored, so
> that other errors can be focused on.
>
> To handle that I added a blacklist to checkpatch. The blacklist holds the
> file names and errors which are ignored. The output is modified to
> remove the errors from the list and not to count them.
>
> When the blacklist kicks in there is a note that does list how many
> errors got removed and that it was due to a blacklist entry. There is
> also a new option "--noblacklist" that allows the errors to be added
> back as it was without the blacklist.
>

So, for this piece of code:

TRACE_EVENT(...

TP_fast_assign(
__entry->foo = bar( xxx );
),
)

checkpatch won't report the spaces inside bar()?
If so, I don't like this patch.

Could you just teach checkpatch to recognize those macros used
in TRACE_EVENT(), if those coding-style "errors" bother you
so much that you can't put up with them?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/