[tip:perf/urgent] perf tools: Fix buffer allocation

From: tip-bot for Eric Dumazet
Date: Thu Sep 24 2009 - 09:17:11 EST


Commit-ID: a255a9981a8566a1efabec983b7811e937e662d2
Gitweb: http://git.kernel.org/tip/a255a9981a8566a1efabec983b7811e937e662d2
Author: Eric Dumazet <eric.dumazet@xxxxxxxxx>
AuthorDate: Thu, 24 Sep 2009 15:05:59 +0200
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Thu, 24 Sep 2009 15:11:23 +0200

perf tools: Fix buffer allocation

"perf top" cores dump on my dev machine, if run from a directory
where vmlinux is present:

*** glibc detected *** malloc(): memory corruption: 0x085670d0 ***

Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Cc: <stable@xxxxxxxxxx>
LKML-Reference: <4ABB6EB7.7000002@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>


---
tools/perf/util/module.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/module.c b/tools/perf/util/module.c
index 8f81622..0d8c85d 100644
--- a/tools/perf/util/module.c
+++ b/tools/perf/util/module.c
@@ -423,7 +423,7 @@ static int mod_dso__load_module_paths(struct mod_dso *self)
len += strlen(uts.release);
len += strlen("/modules.dep");

- dpath = calloc(1, len);
+ dpath = calloc(1, len + 1);
if (dpath == NULL)
return err;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/