RE: [PATCH 2/14] bfa: Brocade BFA FC SCSI driver (bfa1)

[Jing Huang]

> > Hi Daniel,
> >
> > I did run checkpatch.pl and it didn't report any ERROR or WARNING. Do
> you use any specific flags?
> 
> No nothing special .. I run it in the following way,
> 
> ./scripts/checkpatch.pl this-is-the-test.patch
> 
> or
> 
> cat this-is-the-test.patch | ./scripts/checkpatch.pl -
> 
> how did you run it? Usually it will report something like the following
> if it finds nothing,
> 
> total: 0 errors, 0 warnings, XXX lines checked
> 
> Your patch has no obvious style problems and is ready for submission.
> 
> 
> 
> Daniel

Thanks. I found the problem. I tried the latest checkpatch in 2.6.31 and it generates a lot of ERRORs about putting parentheses for return. I have been using an older version of checkpatch for patch submission all the time, and therefore I didn't see any problem. I will fix them and resubmit the patch.

Jing 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/