Re: [PATCH 17/63] edac_mce: Add an interface driver to report mceerrors via edac

[Borislav Petkov]

On Fri, Sep 25, 2009 at 04:05:01PM +0200, Arjan van de Ven wrote:
> On Fri, 25 Sep 2009 15:56:26 +0200
> > > 1) edac_mce is not a module (see patch 18). So, just calling a
> > > routine on edac_mce should be safe, even at NMI;
> > 
> > no, I mean the ->check_error member - it could call into a module if
> > i7core_edac is compiled as such.
> 
> calling modular code from NMI is not a fatal event though.

No, not really. However, I remember Andi raising a stability concern one
time whether it'd be such a good idea to allow modules to hook into MCE
critical path when the system is already unstable and about to panic.

Therefore, we might want to decode critical MCEs in core kernel code and
non-critical later, at a more appropriate time (aka in modules).

Hmm?

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/