Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're notused

[Alan Cox]

On Mon, 28 Sep 2009 15:55:44 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > > Possibly legacy_pty_init() should be passing this to tty_set_operations()
> > > rather than pty_ops.
> > 
> > It should indeed, otherwise the BSD pty locking ioctl fails.
> 
> In that case, what should be using pty_ops?  If CONFIG_LEGACY_PTYS=n, then I
> see:
> 
> 	drivers/char/pty.c:314: warning: unused variable `pty_ops'

You'd have to go and check the old code but I believe one side of the BSD
pair uses pty_ops the other pty_bsd ops, and unix98 uses different ops
again.

All it does is make sure the right ioctls appear on the right devices.
Quite why the can't all use one and a simple if in the ioctl handler I'm
not sure

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/