Re: [PATCH 2/5] x86, mce: rename finished to valid in struct mce

[Hidetoshi Seto]

Andi Kleen wrote:
> struct mce is exported to user space. I don't think it's a good idea
> to rename fields in exported structures like this.  That just causes confusion.

I don't know any other real user of this struct than the mcelog and the
mce test suite.  In other words, I expected that you (Huang and Andi) are
only users who may be confused by this kind of change.

I believe this exported struct is not well defined.
At least I could not figure out why we need to pass the value of .finished
from/to user space.

However, this change is not urgent thing.  I'll put aside this for now.


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/