Re: checkpatch as a tool (was Re: [RFC][PATCH] SCHED_EDFscheduling class)

From: Pavel Machek
Date: Wed Sep 30 2009 - 08:04:52 EST


On Tue 2009-09-22 17:51:43, Daniel Walker wrote:
> On Tue, 2009-09-22 at 21:11 +0200, Ingo Molnar wrote:
>
> > Now at patch patches/sched_edf-scheduling-class.patch
> >
> > Daniel is a kind of self-elected joker-bot on lkml, running checkpatch
> > out of .procmailrc and annoying people with trivial comments,
> > distracting from the real discussion. Raistlin, feel free to ignore him
> > in the future.

Good, I was afraid Ingo would actually like that behaviour.

> You want to talk about it constructively or not? I'll stop sending those
> emails if it's actually negative , but I don't think it is..

Getting you 'have misplaced parenthesis' feedback on a bugfix, on a
file thatt has 1001 checkpatch problems, and when the patch does not
actually introduce the problem... certainly is unwelcome.

What about simply avoiding the mails when the file being changed
already has checkpatch problems?
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/