Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intializationinto an indepedent function.

From: Zachary Amsden
Date: Wed Sep 30 2009 - 11:53:51 EST


On 09/29/2009 10:45 PM, Avi Kivity wrote:
On 09/29/2009 11:38 PM, Zachary Amsden wrote:
Signed-off-by: Zachary Amsden<zamsden@xxxxxxxxxx>


Looks good.

Is anything preventing us from unifying the constant_tsc and !same paths? We could just do a quick check in the notifier, see the tsc frequency hasn't changed, and return.

Actually, yes. On constant_tsc processors, the processor frequency may still change, however the TSC frequency does not change with it.

I actually have both of these kinds of processors (freq changes with constant TSC and freq changes with variable TSC) so I was able to test both of these cases.

Zach
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/