Re: linux-next: Tree for September 30

From: Kamalesh Babulal
Date: Wed Sep 30 2009 - 12:58:24 EST


* Martin Schwidefsky <schwidefsky@xxxxxxxxxx> [2009-09-30 14:16:41]:

> On Wed, 30 Sep 2009 15:22:54 +0530
> Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> wrote:
>
> > next-20090930 randconfig build breaks, character driver
> >
> > ERROR: "ccw_device_force_console" [drivers/s390/char/raw3270.ko] undefined!
> > make[1]: *** [__modpost] Error 1
>
> This patch should fix the build breakage:

Thanks, the patch fixes the build failure.

> --
> Subject: [PATCH] 3270 console build fix
>
> From: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
>
> Fix this build failure:
> drivers/s390/built-in.o: In function `raw3270_pm_unfreeze':
> (.text+0x3ac04): undefined reference to `ccw_device_force_console'
> with:
> CONFIG_TN3270=y
> CONFIG_TN3270_CONSOLE=n
> CONFIG_TN3215_CONSOLE=n
>
> Reported-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> ---
>
> drivers/s390/char/raw3270.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff -urpN linux-2.6/drivers/s390/char/raw3270.c linux-2.6-patched/drivers/s390/char/raw3270.c
> --- linux-2.6/drivers/s390/char/raw3270.c 2009-09-10 00:13:59.000000000 +0200
> +++ linux-2.6-patched/drivers/s390/char/raw3270.c 2009-09-30 14:14:44.000000000 +0200
> @@ -1361,11 +1361,13 @@ static int raw3270_pm_start(struct ccw_d
>
> void raw3270_pm_unfreeze(struct raw3270_view *view)
> {
> +#ifdef CONFIG_TN3270_CONSOLE
> struct raw3270 *rp;
>
> rp = view->dev;
> if (rp && test_bit(RAW3270_FLAGS_FROZEN, &rp->flags))
> ccw_device_force_console();
> +#endif
> }
>
> static struct ccw_device_id raw3270_id[] = {
> --
> blue skies,
> Martin.
>
> "Reality continues to ruin my life." - Calvin.
>

Kamalesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/