Re: [PATCH 2/2] x86: UV hardware performance counter and topologyaccess

From: Ingo Molnar
Date: Thu Oct 01 2009 - 03:47:58 EST



* Russ Anderson <rja@xxxxxxx> wrote:

> Adds device named "/dev/uv_hwperf" that supports an ioctl interface
> to call down into BIOS to read/write memory mapped performance
> monitoring registers.

That's not acceptable - please integrate this with perf events properly.
See arch/x86/kernel/cpu/perf_event.c for details.

Precisely what kinds of events are being exposed by the UV BIOS
interface? Also, how does the BIOS get them? The BIOS should be left out
of that - the PMU driver should know about and access hardware registers
directly.

If any of this needs enhancements in kernel/perf_event.c we'll be glad
to help out.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/