Re: [PATCH 29/34] move virtballoon_remove to .devexit.text

[Uwe Kleine-König]

Hello Michael,

On Thu, Oct 01, 2009 at 11:35:48AM +0200, Michael S. Tsirkin wrote:
> On Thu, Oct 01, 2009 at 10:28:33AM +0200, Uwe Kleine-König wrote:
> > The function virtballoon_remove is used only wrapped by __devexit_p so
> > define it using __devexit.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> 
> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> 
> Generally I think all remove pointers on virtio bus are devexit. 
That means I missed something?

>                                                                   How do
> you find all these,
I have a script that only generates few false-positives (and an unknown
number of false-negatives).

>                     and remember to mark new ones properly?
I don't understand that question.  You need to have understood how these
markings work and do it right.

>                                                              Can we
> annotate the remove pointer in struct virtio_driver so that sparse can
> find them?
I already thought about a runtime check.  I didn't implement anything
yet though.

I can give you my script that finds problems for platform_drivers.  You
should be able to adapt it for other types of drivers easily.  When most
platform_driver patches are in, I plan to look at pci.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/