Re: [PATCH] trace: fix missing assignment in trace_ctxwake_*

From: Frédéric Weisbecker
Date: Fri Oct 02 2009 - 08:49:07 EST


2009/10/1 Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>:
> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
>
> The state char variable S should be reassigned, if S == 0.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>


Good catch, we are indeed missing the state of the task that is going to sleep
for the context switch events (in the raw mode).

Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Fortunately the problem arises with the sched_switch/wake_up tracers, not
the sched trace events.
The formers are legacy now. But still, that was buggy.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/