Re: [121/136] mm: fix anonymous dirtying

[Greg KH]

On Fri, Oct 02, 2009 at 05:34:03PM +0100, Hugh Dickins wrote:
> On Thu, 1 Oct 2009, Greg KH wrote:
> > 2.6.31-stable review patch.  If anyone has any objections, please let us know.
> > 
> > ------------------
> > From: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
> > 
> > commit 1ac0cb5d0e22d5e483f56b2bc12172dec1cf7536 upstream.
> > 
> > do_anonymous_page() has been wrong to dirty the pte regardless.
> > If it's not going to mark the pte writable, then it won't help
> > to mark it dirty here, and clogs up memory with pages which will
> > need swap instead of being thrown away.  Especially wrong if no
> > overcommit is chosen, and this vma is not yet VM_ACCOUNTed -
> > we could exceed the limit and OOM despite no overcommit.
> 
> Thanks a lot for including this little fix in 2.6.31.2.
> It is equally relevant to both 2.6.27.36 and 2.6.30.9,
> so if not too late, please consider adding it into those too.

Ok, will do.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/