Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?

[Paul Fulghum]

lenrek@xxxxxx wrote:
> On 2009/10/03, at 0:33, Paul Fulghum wrote:
> 
>> lenrek@xxxxxx wrote:
>>> How about the BKL calls in synclinkmp.c, synclink.c, and  
>>> synclink_gt.c?
>>> Can they be safely eliminated?
>> I looked those over and yes, the BKL can be removed
>> from those as well. All 4 synclink drivers are mostly
>> variations on the same code.
>>
>> It looks like the lock_kernel calls were blindly pushed down
>> for safety during the initial transition, but all of the
>> functions covered either use device specific locking or
>> do not require locking.
> 
> Many thanks.  I enclose a patch against 2.6.31.1
> which eliminates the BKL calls from the synclink drivers.

Acked-by: Paul Fulghum <paulkf@xxxxxxxxxxxxx>

-- 
Paul Fulghum
MicroGate Systems, Ltd.
=Customer Driven, by Design=
(800)444-1982
(512)345-7791 (Direct)
(512)343-9046 (Fax)
Central Time Zone (GMT -5h)
www.microgate.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/