Re: [this_cpu_xx V4 12/20] Move early initialization of pagesetsout of zone_wait_table_init()

[Tejun Heo]

Christoph Lameter wrote:
> On Sat, 3 Oct 2009, Tejun Heo wrote:
> 
>>>  arch/ia64/kernel/setup.c       |    1 +
>>>  arch/powerpc/kernel/setup_64.c |    1 +
>>>  arch/sparc/kernel/smp_64.c     |    1 +
>>>  arch/x86/kernel/setup_percpu.c |    2 ++
>>>  include/linux/mm.h             |    1 +
>>>  mm/page_alloc.c                |   40 +++++++++++++++++++++++++++++-----------
>>>  mm/percpu.c                    |    2 ++
>> Hmmm... why not call this function from start_kernel() after calling
>> setup_per_cpu_areas() instead of modifying every implementation of
>> setup_per_cpu_areas()?
> 
> Because it has to be called immediately after per cpu areas become
> available. Otherwise page allocator uses will fail.

But... setup_per_cpu_area() isn't supposed to call page allocator and
start_kernel() is the only caller of setup_per_cpu_areas().

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/