Re: bug in elevator/cfq regarding start_time?

[Jens Axboe]

On Mon, Oct 05 2009, Corrado Zoccolo wrote:
> On Mon, Oct 5, 2009 at 5:08 PM, Corrado Zoccolo <czoccolo@xxxxxxxxx> wrote:
> > On Sun, Oct 4, 2009 at 10:59 PM, Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
> >> Good spotting! So we can either add the same copy in cfq, or we can just
> >> move the ->start_time check and assignment in attempt_merge() to post
> >> the elv_merge_requests() call. I think the latter would work fine, but
> >> I'll check and fix tomorrow.
> >
> > I think there is still something buggy regarding those timestamps.
> False alarm. I just found that the list was not yet filled at that
> place in the code.

OK, it did look a bit puzzling. FWIW, this is what I committed
yesterday:

http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=30996f40bffe73f05abb92a4cec254befa8cecf7

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/