Re: bug in elevator/cfq regarding start_time?

From: Jens Axboe
Date: Tue Oct 06 2009 - 04:55:58 EST


On Tue, Oct 06 2009, Corrado Zoccolo wrote:
> On Tue, Oct 6, 2009 at 9:12 AM, Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
> > On Mon, Oct 05 2009, Corrado Zoccolo wrote:
> >> On Mon, Oct 5, 2009 at 5:08 PM, Corrado Zoccolo <czoccolo@xxxxxxxxx> wrote:
> >> False alarm. I just found that the list was not yet filled at that
> >> place in the code.
> >
> > OK, it did look a bit puzzling. FWIW, this is what I committed
> > yesterday:
> >
> > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=30996f40bffe73f05abb92a4cec254befa8cecf7
> Yes, I was testing this one, but put the testing code in the wrong place.
> After fixing the testing code, I verified it is working correctly.
> Now, both the start time and fifo_time are monotonic.

OK good, thanks for confirming! I'll push it for 2.6.32. And thanks for
spotting this in the first place, the fixing part was the easy bit.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/