Re: [PATCH v2] perf tools: Start the perf.data mapping at dataoffset in perf trace

[Frederic Weisbecker]

On Tue, Oct 06, 2009 at 09:21:26PM +0200, Frederic Weisbecker wrote:
> Currently, we are mapping perf.data in the beginning of the file
> and use the data offset as a buffer offset. This may exceed the
> mapping area if the data offset is upper than page_size * mmap_window
> and result in a page fault (thing that happen if we merge trace.info
> in perf.data).
> 
> Instead, let's start the mapping in the page that matches our data
> offset.
> 
> v2: Drop a junk from another patch (trace_report() removal)
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Mike Galbraith <efault@xxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Tom Zanussi <tzanussi@xxxxxxxxx>


I just tested the trace.info drop with perf sched, and we have the same bug
with mmap.

I guess we should rather have a common helper to use mmap on perf.data
and rely on a callback to process the events.
I'm putting this in my TODO list.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/