Re: [this_cpu_xx V5 19/19] SLUB: Experimental new fastpath w/ointerrupt disable

[Peter Zijlstra]

On Tue, 2009-10-06 at 22:54 -0400, Mathieu Desnoyers wrote:
> > +     local_irq_save(flags);
> > +     preempt_enable();       /* Get rid of count */
> 
> Ugh ? Is that legit ?

Yeah, it reads rather awkward, and the comment doesn't make it any
better, but what he's doing is:

slab_alloc()
  preempt_disable();
  __slab_alloc()
    local_irq_save(flags);
    preempt_enable();


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/