Re: [PATCH 09/45] writeback: quit on wrap for .range_cyclic (pohmelfs)

[Evgeniy Polyakov]

Hi.

On Wed, Oct 07, 2009 at 03:38:27PM +0800, Wu Fengguang (fengguang.wu@xxxxxxxxx) wrote:
> Convert wbc.range_cyclic to new behavior: when past EOF, abort writeback
> of the inode, which instructs writeback_single_inode() to delay it for 
> a while if necessary.
> 
> It removes one inefficient .range_cyclic IO pattern when writeback_index
> wraps:
> 	submit [10000-10100], (wrap), submit [0-100]
> In which the submitted pages may be consisted of two distant ranges.
> 
> It also prevents submitting pointless IO for busy overwriters.

I have no objections against this patchset, since I followed the
upstream writeback behaviour and did not personally observe such wraps
which would be otherwise handled in a single run.

> CC: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
> Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/