Re: [PATCH 3/5] checkpatch: add a blacklist
From: Alan Cox
Date: Wed Oct 07 2009 - 11:12:10 EST
> Right it's a tool .. However, you should use it and you should follow
> it. If for some reason you disagree with the tool you have to give at
> least an arguable reason why, not just "It's a guide", "I don't like the
> coding style." etc..
Those are perfectly good reasons.
> In the case of Steven's code he has an arguable reason why he's not
> following checkpatch..
Checkpatch is not very bright, it has no understanding of style beyond
playing with pattern regexps. It's a rather dim tool that helps people
get work done. (*)
When used at random to "validate" submissions to the kernel the result is
about as useful as a square wheel on a hovercraft.
Alan
(*) or as some would have it a rather dim tool used by even dimmer tools
to make noise on kernel list.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/