Re: [PATCH 6/7] x86 dumpstack: fix printing of stack dump loglevels

[Alan Jenkins]

Linus Torvalds wrote:
> On Wed, 7 Oct 2009, Alan Jenkins wrote:
>   
>> Changing printk() to accept loglevels in the middle of the string again
>> would be non-trivial.  Let's accept this limitation and simply split the
>> above code into two separate calls to printk().
>>     
>
> Actually, let's just drop the log_lvl printout in the middle.
>
> And to do that, let's clean up printk() a bit further - just make it say 
> "if there is no loglevel, use the previous loglevel". That's going to 
> simplify _all_ kinds of multi-line code.
>   

I think its more of a special case.  It's most useful where we output a
multi-line hexdump (or some other sort of array).  I think that's just
stack dumps (albeit potentially one for each architecture).  Is there
really anything else?  If not, I would lean against doing this.

None of the other architectures seem to set any loglevel in
dump_stack(), so this would change their behaviour.  I.e. dump_stack()
would print with the current loglevel, whatever that is.  That's a neat
behaviour and we could simplify x86 to match.  But it seems less simple
overall.  This one arch function would rely implicitly on the new, not
immediately obvious behaviour of printk().

> As far as I can tell, that's a oneliner: make 'current_log_level' be a 
> 'static' variable.
>
> Wouldn't that be much simpler for everybody?
>
> (And yes, if you mix multi-line messages that are printed as separate 
> printk's and with different loglevels, output will be confused. But quite 
> frankly, it will be confused regardless)
>   

It is more obvious that there is confusion when you see "<0>" in the
middle of a line though :-).

Regards
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/