Re: [PATCH] mfd/mc13783: near complete rewrite
From: Uwe Kleine-König
Date: Sun Nov 01 2009 - 16:07:29 EST
Hello,
On Fri, Oct 23, 2009 at 10:38:43PM +0200, Uwe Kleine-König wrote:
> This fixes several things while still providing the old API:
>
> - simplify and fix locking
> - better error handling
> - don't ack all irqs making it impossible to detect a reset of the
> rtc
> - use a timeout variant to wait for completion of ADC conversion
> - provide platform-data to regulator subdevice (This allows making
> struct mc13783 opaque for other drivers after the regulator driver is
> updated to use its platform_data.)
> - expose all interrupts
> - use threaded irq
>
> After all users in mainline are converted to the new API, some things
> (e.g. mc13783-private.h) can go away.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> ---
> drivers/mfd/mc13783-core.c | 789 ++++++++++++++++++++++++-----------
> include/linux/mfd/mc13783-private.h | 208 +---------
> include/linux/mfd/mc13783.h | 122 +++++--
> 3 files changed, 651 insertions(+), 468 deletions(-)
I havn't received feedback yet for this patch.
I'd like to start updating the regulator driver, but only when I now my
updates here are considered sensible.
As this is a rewrite, reading the patch might not be that easy. So if
you only want to see the new version, you can find it at
http://git.pengutronix.de/?p=ukl/linux-2.6.git;a=blob;f=drivers/mfd/mc13783-core.c;h=63a5104bf2ea83be817587f83a53beaabd418a6b;hb=e49c74fa5001b54632b704deb837e98bc5b307c0
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/