Re: dream: glue for mmc controller

From: Russell King - ARM Linux
Date: Sun Nov 08 2009 - 04:10:50 EST


On Sun, Nov 08, 2009 at 09:13:14AM +0100, Pavel Machek wrote:
> > > +#include <asm/io.h>
> > > +#include <asm/gpio.h>
> > linux/gpio.h
> > linux/io.h
>
> I got compile errors when trying to use linux/gpio.h:
>
> arch/arm/mach-msm/board-dream-gpio.c: In function
> 'dream_gpio_configure':
> arch/arm/mach-msm/board-dream-gpio.c:109: error: 'GPIOF_OUTPUT_LOW'
> undeclared (first use in this function)

This means it's abusing the gpio header files - which are intended for
the generic GPIO support, but are being used for this platforms private
non-generic GPIO based stuff.

> arch/arm/mach-msm/board-dream-gpio.c:291: error: 'IRQF_TRIGGER_HIGH'
> undeclared (first use in this function)
> arch/arm/mach-msm/board-dream-gpio.c:293: error: implicit declaration
> of function 'set_irq_wake'

That's showing its missing a linux/interrupt.h include.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/