Re: [PATCH] x86: use x86_platform for iommu_shutdown

[Ingo Molnar]

* FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:

> This patch cleans up pci_iommu_shutdown() a bit to use x86_platform
> (similar to how IA64 initializes an IOMMU driver).
> 
> This adds iommu_shutdown() to x86_platform to avoid calling every
> IOMMUs' shutdown functions in pci_iommu_shutdown() in order. The IOMMU
> shutdown functions are platform specific (we don't have multiple
> different IOMMU hardware) so the current way is pointless.
> 
> An IOMMU driver sets x86_platform.iommu_shutdown to the shutdown
> function if necessary.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> ---
>  arch/x86/include/asm/amd_iommu.h |    2 --
>  arch/x86/include/asm/gart.h      |    4 ----
>  arch/x86/include/asm/iommu.h     |    2 +-
>  arch/x86/include/asm/x86_init.h  |    1 +
>  arch/x86/kernel/amd_iommu_init.c |    6 +-----
>  arch/x86/kernel/crash.c          |    5 ++---
>  arch/x86/kernel/pci-dma.c        |    7 -------
>  arch/x86/kernel/pci-gart_64.c    |    6 ++++--
>  arch/x86/kernel/reboot.c         |    4 ++--
>  arch/x86/kernel/x86_init.c       |    2 ++
>  10 files changed, 13 insertions(+), 26 deletions(-)

Applied, thanks - this is a really nice cleanup!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/