Re: [PATCH v4 07/12] vsprintf: factor out skip_space code in a separate function
From: André Goddard Rosa
Date: Sun Nov 08 2009 - 10:53:09 EST
On Sun, Nov 8, 2009 at 1:44 PM, Jan Engelhardt <jengelh@xxxxxxxxxx> wrote:
>
> On Saturday 2009-11-07 16:16, André Goddard Rosa wrote:
>
>>It decreases code size:
>
> And may increase runtime. If GCC determined that skip_space
> itself (without the noinline you added) is going to be inlined,
> let it go ahead.
Later in the series, when stepping over the whole tree for using that function,
I changed it to let gcc decide instead as you correctly pointed out.
Thanks for reviewing,
André
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/