Re: [RFC, PATCH] cfq-iosched: remove redundant queuing detection code

From: Jeff Moyer
Date: Tue Nov 10 2009 - 10:03:43 EST


Corrado Zoccolo <czoccolo@xxxxxxxxx> writes:

> The core block layer already has code to detect presence of command
> queuing devices. We convert cfq to use that instead of re-doing the
> computation.

This sounds like a good idea to me, and it appears the same number of
requests will be used to detect command queuing. I'm surprised we can't
just query each device to detect this, honestly.

One thing you missed, though, was removing the CFQ_HW_QUEUE_MIN define.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/