Re: Reverting 5d423 fixes loading of ath9k on Acer Extensa 7630EZ

[Luis R. Rodriguez]

On Mon, Nov 9, 2009 at 7:49 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote:
> On Sun, Nov 8, 2009 at 11:15 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>>
>> * Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote:
>>
>>> On Wed, Nov 4, 2009 at 11:14 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>>> >
>>> > * Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>> >
>>> >> On Wed, 4 Nov 2009, Luis R. Rodriguez wrote:
>>> >> >
>>> >> > Can you please consider reviewing this issue and help determine if
>>> >> > this indeed needs to be reverted for 2.6.32 and the next 2.6.31.y.
>>> >> >
>>> >> > I am curious if other devices would work by reverting this as well.
>>> >> > [ ... ] For details please feel free to check:
>>> >> >
>>> >> > http://bugzilla.kernel.org/show_bug.cgi?id=14402
>>> >>
>>> >> That same commit was the cause for
>>> >>
>>> >> ?? ?? ?? http://bugzilla.kernel.org/show_bug.cgi?id=13940
>>> >>
>>> >> and we just increased the rounding to make it go away (see commit
>>> >> 15b812f1). But that was a hack.
>>> >>
>>> >> And if that didn't help the ath9k case, then we should just revert
>>> >> entirely.
>>> >
>>> > Agreed - below is the combo 15b812f1 + 5d423ccd revert. (Would be nice
>>> > to get the boot log of the latest post-15b812f1 kernel that Yinghai
>>> > asked for before we revert, in the hope of better understanding the
>>> > problem.)
>>>
>>> Bernhard has confirmed the new patch fixes this issue.
>>
>> Good - so latest kernels should be fine (on Bernhard's box) and no
>> change is needed, right?
>
> Yea, but it does mean we need a fix propagated down to older kernels.

Greg, please consider applying 15b812f1d0 to stable 2.6.31 as it fixes
an issue introduced on 2.6.31 and only fixed now for 2.6.32. This
should fix an issue when loading either sky2 or ath9k on some specific
platforms.

The details for the ath9k debugging are available on this bug:

http://bugzilla.kernel.org/show_bug.cgi?id=14402

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/