Re: [PATCH 3/6] mm: CONFIG_MMU for PG_mlocked

From: KOSAKI Motohiro
Date: Tue Nov 10 2009 - 20:22:33 EST


> Remove three degrees of obfuscation, left over from when we had
> CONFIG_UNEVICTABLE_LRU. MLOCK_PAGES is CONFIG_HAVE_MLOCKED_PAGE_BIT
> is CONFIG_HAVE_MLOCK is CONFIG_MMU. rmap.o (and memory-failure.o)
> are only built when CONFIG_MMU, so don't need such conditions at all.
>
> Somehow, I feel no compulsion to remove the CONFIG_HAVE_MLOCK*
> lines from 169 defconfigs: leave those to evolve in due course.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>

I don't recall why Lee added this config option. but it seems very
reasonable and I storongly like it.

At least, vmscan folks never said "please try to disable CONFIG_MLOCK".
It mean this option didn't help our debug.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/