Re: [PATCH] x86 VSDO: fix Kconfig help

[AmÃrico Wang]

On Wed, Nov 11, 2009 at 7:46 AM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> COMPAT_VDSO has 2 help text blocks, but kconfig only uses the
> last one found, so merge the 2 blocks.
>
> It would be real nice if kconfig would warn about this.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Looks good.

Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

Thanks!

> ---
> Âarch/x86/Kconfig | Â Â4 ++--
> Â1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lnx-2632-rc6.orig/arch/x86/Kconfig
> +++ lnx-2632-rc6/arch/x86/Kconfig
> @@ -1601,12 +1601,12 @@ config COMPAT_VDSO
> Â Â Â Âprompt "Compat VDSO support"
> Â Â Â Âdepends on X86_32 || IA32_EMULATION
> Â Â Â Â---help---
> - Â Â Â Â Map the 32-bit VDSO to the predictable old-style address too.
> - Â Â Â ---help---
> Â Â Â Â ÂSay N here if you are running a sufficiently recent glibc
> Â Â Â Â Âversion (2.3.3 or later), to remove the high-mapped
> Â Â Â Â ÂVDSO mapping and to exclusively use the randomized VDSO.
>
> + Â Â Â Â Map the 32-bit VDSO to the predictable old-style address too.
> +
> Â Â Â Â ÂIf unsure, say Y.
>
> Âconfig CMDLINE_BOOL
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/