Re: [RFC] new -stable tag variant, Git workflow question

[James Bottomley]

On Wed, 2009-11-11 at 12:00 -0800, Linus Torvalds wrote:
> 
> On Wed, 11 Nov 2009, James Bottomley wrote:
> > 
> > The slight problem is that further down, to generate the patch the
> > script uses git format-patch -k --stdout commit^..commit.  For a merge
> > commit, this will generate a patch equivalent to the entire branch that
> > was merged, even though the commit message will only pick out some of
> > these ... is this OK?
> 
> Don't do that.
> 
> Since you want to show a single commit, not a commit range, don't use 
> format-patch, use something like
> 
> 	git show --pretty=email -M --cc --stat $commit
> 
> instead. That will not show the difference between a commit and its 
> first parent (which for a merge diff is more than one commit, and can be 
> absolutely _huge_), but will show just the named commit (which for a merge 
> commit will usually be an empty diff, but will show how conflicts were 
> resolved if they weren't just taken from one or the other side).
> 
> (Of course, maybe you'll want to change the exact flags in question. For 
> example, '--stat' for merge commits is often useful, but only if the merge 
> was done by an upper-level maintainer. Anybody who does reverse merges 
> will just get totally meaningless diffstats, since the diffstat is always 
> done against the first parent, so anybody who does back-merges will see 
> the stat of everthing _I_ have merged in the meantime, which is generally 
> not useful)

Right ... that's why I was wondering if Greg still needs the diff.  If
not, I'll just send standard git log output with no diff.  If he does,
I'll use something like the above.

So, now that you're showing an interest in all of this, how about I send
you the final update hook to add to your tree?  It will produce less
latency than the cron job I run on kernel.org to pull your tree into one
I have here ever twenty minutes or so and run the hooks.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/