Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd)

From: Oliver Neukum
Date: Wed Nov 11 2009 - 16:12:47 EST

Next message: Roel Kluin: "[PATCH] ftrace: return error instead of 12 bytes read"
Previous message: Oliver Neukum: "Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd)"
In reply to: Oleg Nesterov: "Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) onresume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhapsrelated to preempt_count leakage in keventd)"
Next in thread: Oleg Nesterov: "Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) onresume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhapsrelated to preempt_count leakage in keventd)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Am Mittwoch, 11. November 2009 21:24:33 schrieb Oleg Nesterov:
> > So, it looks like the bug is in btusb_destruct(), which should call
> > cancel_work_sync() on data->waker before freeing 'data'. I guess it
> > should do the same for data->work.
>
> Or. btusb_suspend() and btusb_close() do cancel_work_sync(data->work),
> perhaps they should cancel data->waker as well, I dunno.
>
> I added Oliver to cc.

btusb_close() must do it. btusb_suspend() must not do it.

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/