Re: Fix argument order in memset call in ./drivers/media/common/ir-functions.c

[AmÃrico Wang]

On Thu, Nov 12, 2009 at 5:59 AM, Dave Jones <davej@xxxxxxxxxx> wrote:
> Size is the third argument, not the second.
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>


Definitely yes.

Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

>
> diff --git a/drivers/media/common/ir-functions.c b/drivers/media/common/ir-functions.c
> index 655474b..abd4791 100644
> --- a/drivers/media/common/ir-functions.c
> +++ b/drivers/media/common/ir-functions.c
> @@ -64,7 +64,7 @@ void ir_input_init(struct input_dev *dev, struct ir_input_state *ir,
>
> Â Â Â Âir->ir_type = ir_type;
>
> - Â Â Â memset(ir->ir_codes, sizeof(ir->ir_codes), 0);
> + Â Â Â memset(ir->ir_codes, 0, sizeof(ir->ir_codes));
>
> Â Â Â Â/*
> Â Â Â Â * FIXME: This is a temporary workaround to use the new IR tables
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/