Re: [PATCH] pxa: make index mfp unsigned in mfp_read() and write()

[Eric Miao]

On Thu, Nov 12, 2009 at 12:05 AM, Roel Kluin <roel.kluin@xxxxxxxxx> wrote:
> When signed, it is possible in theory to pass a negative mfp,
> and read/write outside the array bounds.
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> Âarch/arm/plat-pxa/include/plat/mfp.h | Â Â4 ++--
> Âarch/arm/plat-pxa/mfp.c       Â|  Â4 ++--
> Â2 files changed, 4 insertions(+), 4 deletions(-)
>
> I did not observe the passing of a negative mfp anywhere so this
> can be considered as a cleanup. Alternatively I could introduce
> a `mfp < 0' check in mfp_{read,write} instead if desired.
>

I'd prefer to have a check in mfp_{read,write} instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/