Re: [PATCH] forcedeth: mac address fix

From: David Miller
Date: Fri Nov 13 2009 - 22:52:29 EST


From: "Stanislav O\. Bezzubtsev" <stas@xxxxxxxxxxxxx>
Date: Fri, 13 Nov 2009 15:22:55 +0300

> Set second bit of randomly generated mac. That marks MAC
> as locally assigned. IEEE802.3, section one, 3.2.3.
>
> Signed-off-by: Stanislav O. Bezzubtsev <stas@xxxxxxxxxxxxx>

Do you know why this driver even has this bug?

It's because it does not use random_ether_addr() and tries to
do it by hand all by itself.

Please fix this bug for real by having the driver use the proper
interface to calculate a randomized ethernet address.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/