Re: [PATCH] mouse button 1 emulation for mac_hid

From: Soeren Sonnenburg
Date: Sat Nov 14 2009 - 05:31:52 EST


On Fri, 2009-11-13 at 21:42 -0800, Dmitry Torokhov wrote:
> Hi Soeren,

Hi Dmitry,

> On Mon, Nov 09, 2009 at 11:28:51AM +0100, Soeren Sonnenburg wrote:
> > (this is a resent with all the people included in the CC that git
> > blame'd they are the authors).
> >
> > Dear all,
> >
> > I am not sure what the future of mac_hid is (the source says will be
> > removed, but since 9 years). In case it stays in kernel the attached
> > patch adds support for mouse button 1 emulation. If this driver stays in
> > the kernel I would also suggest to rename it - it is not mac specific (I
> > am using this on a netbook).
> >
> > Rationale? Broken touchpads, within linux unsupported (multi-)touchpads
> > where click and hold + moving the mouse does not work (yet?).
> >
>
> I would rather fix the touchpads so they work properly than pile more
> quirks in kernel.

Well I guess this whole mouse button emulation should not exist (not
only not in the kernel). But given that it is hard to fix a touchpad
that has no or only one mouse button ... I don't know.

Anyway, the patch is really small/non-intrusive but if it is not
appropriate I can - thanks to git - easily have it in some local
branch :)

Soeren
--
For the one fact about the future of which we can be certain is that it
will be utterly fantastic. -- Arthur C. Clarke, 1962

Attachment: signature.asc
Description: This is a digitally signed message part