Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to&proc_dointvec,

[Joe Perches]

On Sun, 2009-11-15 at 19:20 +0100, Julia Lawall wrote:
> Searching for things that are declared as functions (either a definition 
> or a prototype), and then referenced as &f gives over 2000 results in 
> almost 600 files.

Just curious, do you know how many are referenced
without the &?

> Here are a couple of typical examples:
> 
> arch/arm/mach-omap1/clock.c:
> 
> static const struct clkops clkops_dspck = {
>        .enable         = &omap1_clk_enable_dsp_domain,
>        .disable        = &omap1_clk_disable_dsp_domain,
>  };
> 
> arch/arm/mach-omap1/serial.c:
> 
>        ret = request_irq(gpio_to_irq(gpio_nr), &omap_serial_wake_interrupt,
>                           IRQF_TRIGGER_RISING, "serial wakeup", NULL);
> 
> Should both cases lose the initial &?

If what is desired is kernel wide consistent use, yes.
What I would like is file/subsystem consistent use.

Looking at sysctl.c and seeing that different use
stand out was odd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/